Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add a missing return type for _hue2rgb #51285

Merged
merged 1 commit into from Jun 7, 2018
Merged

[Fix] Add a missing return type for _hue2rgb #51285

merged 1 commit into from Jun 7, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2018 •
edited by ghost
Loading

Change Logs:

  1. /vscode/src/vs/base/common/color.ts：
    _hue2rgb should have a return type in ts. The type shouldn't be missing.

@aeschli aeschli merged commit d5961f5 into microsoft:master Jun 7, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 7, 2018

Thanks @MaleDong !

@aeschli aeschli added this to the June 2018 milestone Jun 7, 2018
@aeschli aeschli self-assigned this Jun 7, 2018
@ghost
Copy link
Author

ghost commented Jun 7, 2018 •
edited by ghost
Loading

Nothing special :)
BTW：It seems that your build tool is wrong……? Publish part isn't working properly?!
:D

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
June 2018
Development

Successfully merging this pull request may close these issues.
1 participant
@aeschli