Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown and common toolbar icons consistency pass #50484

Merged
merged 5 commits into from
Jun 3, 2018
Merged

Markdown and common toolbar icons consistency pass #50484

merged 5 commits into from
Jun 3, 2018

Conversation

chryw
Copy link
Contributor

@chryw chryw commented May 25, 2018

#50438
@misolori @bpasero
I did a consistency pass to some icons on the editor top right toolbar area.

  • visually aligned these icons
  • aligned svg code style (responsive, hide halo and foreground, etc.)
  • removed some unnecessary css styles so they don't override the global size of these icons

There might be other icons could show up in that area. I only tested below icons and made sure they look good. Please let me know if this change makes other icons inconsistent.

@bpasero bpasero added this to the May 2018 milestone May 26, 2018
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chryw the ellipsis icon seems a bit inconsistent now:

Search (new left, old right, seems to be smaller now):
image

Panel (new left, old right, seems to be much larger now):
image

@bpasero
Copy link
Member

bpasero commented Jun 1, 2018

ping @chryw @misolori

@chryw
Copy link
Contributor Author

chryw commented Jun 1, 2018

@bpasero will fix today

@bpasero bpasero merged commit 749a1bf into microsoft:master Jun 3, 2018
@bpasero
Copy link
Member

bpasero commented Jun 3, 2018

@chryw thanks, I merged this to master for our June release 👍

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants