Added background ANSI colour codes #49764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielfrankcom thanks a lot for this PR, let's first merge in the previous one and then we can add this one easily. |
|
@danielfrankcom since we have merged the other PR we could look into this one now. |
|
Yeah I'll need to rebase it, but everything should still work. I'll add the background colour codes to the unit tests too, since it should be relatively easy. |
|
Sounds good, thanks a lot! |
danielfrankcom
force-pushed
the
#47457/background
branch
from
a253dae to
29b9daf
Compare
|
This looks good, let's merge it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #47457.
Due to the fact that the previous changes are not yet on master, I couldn't figure out a way to isolate the relevant changes in this pull request. Focus on the changes in commit a253dae, as the other commit is captured in pull request #49763.