-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the border. Fix #48765 #48825
Conversation
@@ -41,7 +41,6 @@ | |||
cursor: pointer; | |||
height: 35px; | |||
box-sizing: border-box; | |||
border: 1px solid transparent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shizengzhou not a good change, this border is needed when the tab.border
color is set, see:
Maybe we should conditionally set this border if |
@bpasero I have changed my code. |
@shizengzhou I did not realize that we set a border color by default in dark and light theme and we cannot just remove it because the color is actually in use: As you can see, there is a slight black line between the two tabs. I think a better approach would be to not use borders at all for this kind of separation and have it some other way... |
@bpasero Now I don't use borders for the separations. |
@shizengzhou how about keeping the border as is and letting the special case of having a border for the active tab use the |
Color the bottom border for the active tab's ::after element
I found a simpler way via fd7d510 Thanks for the work here, sorry for not pushing it 👍 |
@bpasero I remove the border to fix it.