Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary lines in .travis.yml #46044

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Removing unnecessary lines in .travis.yml #46044

merged 1 commit into from
Mar 19, 2018

Conversation

amtlib-dot-dll
Copy link
Contributor

#46043

As Travis CI have nvm shipped in their images, there is no need to install nvm again

@amtlib-dot-dll
Copy link
Contributor Author

The removed lines does not affect the test result as is shown in the Travis log 🤔 The master branch won't pass the test at all

@joaomoreno joaomoreno closed this Mar 19, 2018
@joaomoreno joaomoreno reopened this Mar 19, 2018
@joaomoreno
Copy link
Member

Looks good! Thanks! 🍻

@joaomoreno joaomoreno added this to the March 2018 milestone Mar 19, 2018
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Mar 19, 2018
@joaomoreno joaomoreno merged commit 8d5d595 into microsoft:master Mar 19, 2018
@amtlib-dot-dll amtlib-dot-dll deleted the patch-1 branch March 19, 2018 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@amtlib-dot-dll @joaomoreno