Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the key bindings for first and last selection in suggestions. #45881

Merged
merged 1 commit into from
Mar 16, 2018
Merged

added the key bindings for first and last selection in suggestions. #45881

merged 1 commit into from
Mar 16, 2018

Conversation

pradeepmurugesan
Copy link
Contributor

For #43511

@jrieken jrieken self-assigned this Mar 15, 2018
@jrieken jrieken added this to the March 2018 milestone Mar 15, 2018
jrieken
jrieken requested changes Mar 15, 2018
View reviewed changes
src/vs/editor/contrib/suggest/suggestController.ts Outdated
weight: weight,
kbExpr: EditorContextKeys.textFocus,
primary: KeyCode.End,
secondary: [KeyCode.End],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use secondary only when the key code is different from primary 🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

src/vs/editor/contrib/suggest/suggestController.ts Outdated
weight: weight,
kbExpr: EditorContextKeys.textFocus,
primary: KeyCode.Home,
secondary: [KeyCode.Home],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jrieken jrieken added the feature-request Request for new features or functionality label Mar 15, 2018
@jrieken jrieken added the suggest IntelliSense, Auto Complete label Mar 15, 2018
@pradeepmurugesan pradeepmurugesan force-pushed the home-end-keys-in-suggestion branch from d6dbc2c to be5030b Compare March 15, 2018 16:56
@pradeepmurugesan
Copy link
Contributor Author

@jrieken sorry my bad.. Didn't know about the secondary thing. Fixed now..

@jrieken
Copy link
Member

jrieken commented Mar 16, 2018

Thanks, looking good

jrieken
jrieken reviewed Mar 16, 2018
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrieken jrieken merged commit 234defc into microsoft:master Mar 16, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken requested changes

Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality on-testplan suggest IntelliSense, Auto Complete
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@pradeepmurugesan @jrieken