Added option whether to show terminal reuse alert

[oriash93]

Allow user to disable "Terminal will be reused by tasks, press any key to close it" message.

fixes #42993

[msftclas]

All CLA requirements met.

[Tyriar]

The terminal.integrated namespace currently doesn't have anything related to tasks/debug in it AFAIK. @dbaeumer is there a tasks settings namespace?

[dbaeumer]

Yes, everything in a tasks.json is basically a setting. So whether the message is shown or not should be a task settings and a global setting in the tasks.json.

The corresponding schema for this is here: https://github.com/Microsoft/vscode/blob/master/src\vs\workbench\parts\tasks\electron-browser\jsonSchema_v2.ts#L7

[oriash93]

I hope I got it right this time.

[dbaeumer]

I looked at the PR and it goes into the right direction. Since tasks have already a presentation property I opt to include it there and not make it a first level attribute. Something:

"presentation": {
    ....
    "reuseMessage": boolean
}

The default should be true although not a falsify value. But it makes more sense then negating the key.

And you only need to adopt the V2 schema since the presentation attribute is only supported on V2.

[oriash93]

@dbaeumer, I force-pushed the whole branch, but take a look at the last commit.

[dbaeumer]

Code looks OK to me. Can you add a test to ensure the configuration is passed correctly.

[oriash93]

@dbaeumer I did the same as with "focus" property in configuration.test.ts.

[dbaeumer]

@oriash93 I need to push this to Mai. I was extremely busy with other things in April. Sorry for that.

[dbaeumer]

Sorry for moving it again. I will promise to look into it first thing in June.

[dbaeumer]

I merged in the PR however I will tweak it a little. Mostly rename reuseMessage to showReuseMessage.

[gwk]

Is this available in the latest insiders build? I can't seem to get it to work but maybe I'm missing something.

[dbaeumer]

I should be in today's insider.

[buggymcbugfix]

Has this not landed in the current release version yet? I'm getting "Property message is not allowed" for "reuseMessage".

[dbaeumer]

The property name is "showReuseMessage"

[umrashrf]

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "clean",
            "type": "shell",
            "windows": {
                "options": {
                    "shell": {
                        "executable": "cmd.exe",
                        "args": [
                            "/d", "/c"
                        ]
                    }
                },
                "command": "del /S /Q *.pyc *.log"
            },
            "presentation": {
                "showReuseMessage": false,
            }
        }
    ]
}

[rustyx]

@dbaeumer so this just hides the message "Press any key to close the terminal.", but user still has to press a key to reveal their terminal??

[dbaeumer]

@rustyx you can still set presentation.reveal to 'never' which will not bring the terminal to the front.