Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get emmet completions from css extension #41652

Merged
merged 8 commits into from
Feb 13, 2018
Merged

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jan 16, 2018

  • Use the "next" version of LS protocol,server and client to get the new completion trigger kind
  • Use emmet helper to get emmet completions at the right places in html,css,less,scss files
  • Re-parse the document and get the non-emmet completions only for new completion requests
  • For completion requests that's meant to complete a previous incomplete request, use the cached non-emmet completions from previous request + new emmet completions
  • Basic Tests

@ramya-rao-a ramya-rao-a changed the title Get emmet completions from css extension WIP: Get emmet completions from css extension Jan 16, 2018
@ramya-rao-a ramya-rao-a self-assigned this Jan 16, 2018
@ramya-rao-a ramya-rao-a changed the title WIP: Get emmet completions from css extension [WIP]: Get emmet completions from css extension Jan 17, 2018
@ramya-rao-a ramya-rao-a force-pushed the emmet-css-extension branch 3 times, most recently from 517cec1 to 9792d88 Compare January 19, 2018 18:40
@ramya-rao-a ramya-rao-a force-pushed the emmet-css-extension branch 2 times, most recently from 017de20 to c0b1058 Compare February 12, 2018 05:21
@ramya-rao-a ramya-rao-a changed the title [WIP]: Get emmet completions from css extension Get emmet completions from css extension Feb 13, 2018
@ramya-rao-a ramya-rao-a merged commit 00f2d8e into master Feb 13, 2018
@ramya-rao-a ramya-rao-a deleted the emmet-css-extension branch July 23, 2018 00:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant