Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global is undefined while polyfilling the native promise #37017

Merged
merged 1 commit into from
Oct 27, 2017
Merged

global is undefined while polyfilling the native promise #37017

merged 1 commit into from
Oct 27, 2017

Conversation

wenshiqi0
Copy link
Contributor

For some reason, I have to compile the monaco-editor by myself.
Recently I update the monaco and found that the editor crash while loading the monaco.
It seems that we need polyfill the promise after we set the global.

2017-10-27 11 45 47

@jrieken
Copy link
Member

jrieken commented Oct 27, 2017

Thanks

@jrieken jrieken merged commit 3520939 into microsoft:master Oct 27, 2017
@jrieken jrieken added this to the October 2017 milestone Oct 27, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Oct 27, 2017
@wenshiqi0 wenshiqi0 deleted the fix-monaco branch October 30, 2017 01:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
2 participants
@wenshiqi0 @jrieken