Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #36924. PowerShell Extension Comment Highlighting Error #36926

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix #36924. PowerShell Extension Comment Highlighting Error #36926

merged 1 commit into from
Oct 26, 2017

Conversation

thomasrayner
Copy link
Member

Fixes issue #36924 to correct a comment highlighting error in the PowerShell extension. Now when the # is escaped with a backtick, therefore not creating a comment, the remainder of the line will not be highlighted as though it were a comment.

Code to reproduce

(($message.description | Select-Object -ExpandProperty `#cdata-section) -replace '(<\/*\w+?>){1,}','').trim()

Result before applying this change

image
This line has incorrect syntax highlighting. The backtick should escape the # and negate the syntax highlighting that colors the remainder of the line green.

Result after applying this change

image

Fixes issue #36924 to correct a comment highlighting error in the PowerShell extension.
@daviwil daviwil self-requested a review October 25, 2017 21:30
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Thomas!

@aeschli aeschli merged commit 9e806c8 into microsoft:master Oct 26, 2017
@aeschli
Copy link
Contributor

aeschli commented Oct 26, 2017

thanks @ThmsRynr !

@aeschli aeschli added this to the October 2017 milestone Oct 26, 2017
@aeschli aeschli added languages-basic Basic language support issues bug Issue identified by VS Code Team member as probable bug labels Oct 26, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants