-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git stashing #29138
Add git stashing #29138
Conversation
@Krzysztof-Cieslak, |
CC: @joaomoreno |
@Krzysztof-Cieslak We don't really need to have the stashes in the model itself. This will just make git status slower since we'd need to call git once more in order to get the stashes. You can just make this call once one of the stash actions runs. Can you fix that? |
Yes, I'll rebase and fix it. |
Ready to review again. |
These changes are not formatted and violate some linting rules we have set. We have configured a git pre-commit hook to validate these for you, which gets set up when you run Also, this goes into infinite recursion. Next time, please run your changes before handing them over to us. Also, this condition will fail when index is zero. Also, I've added functionality to provide a stash message when stashing changes. I've fixed all that up. We do appreciate your contributions very much. But next time, try to follow the guidelines better so we make this smoother. |
Sorry for the trouble @joaomoreno, I haven't paid enough attention to this PR, indeed. My bad :( |
Addresses #1904 which is one of the oldest and most upvoted issues.
Adds 3 new commands for git integration:
git stash
git stash pop
using latest stashgit stash pop
with choosing stash