Fixes issue #28695 with tooltips in Activity Bar #28783
Conversation
|
@rohithkumbharkar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @joaomoreno to be potential reviewers. |
|
@rohithkumbharkar, |
| @@ -310,6 +310,10 @@ export class ViewletActionItem extends ActivityActionItem { | |||
| public render(container: HTMLElement): void { | |||
| super.render(container); | |||
|
|
|||
| if (this._keybinding) { | |||
There was a problem hiding this comment.
@rohithkumbharkar I have a different suggestion where to put this code that makes it much easier. If you look below in that class there is a public set keybinding(keybinding: string). I suggest to set the title in there because it gets computed there:
this.$label.title(title);
this.$badge.title(title);
this.$container.title(title); // <-- add it here
|
@bpasero Yup totally makes sense for some reason I thought I couldn't access $container in there. Made the changes |
Fixes #28695 by making the tool tips consistent