-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces in block comment. #28169 #28238
Conversation
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. At this time, this PR breaks 13 tests. Could you please look into changing tests where it makes sense and fixing any introduced regressions ?
I've fixed the tests. But I have no idea about this one ...
|
@neilsustc, It will cover your contributions to all Microsoft-managed open source projects. |
@neilsustc Thank you, I have closed and reopened the PR to get travis to rerun the build. This has also triggered our Contribution License Agreement bot to re-evaluate the PR, and, due to the increase in changed lines count, it now requires an agreement. Could you please go through the flow the bot asks for, it is very simple. |
@neilsustc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Thanks for your patience 😉 |
Very nice. Thank you for your contribution @neilsustc ❤️ |
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
This PR: microsoft/vscode#28238 inserts spaces inside block comments, which affects VSCodeVim tests.
Resolve #28169.
According to that in
lineCommentCommand.ts
.