Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Markdown language configuration #28172

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Default Markdown language configuration #28172

merged 2 commits into from
Jun 7, 2017

Conversation

yzhang-gh
Copy link
Contributor

Changes

  • use new autoClosingPairs grammar
  • add `, <> to autoClosingPairs
  • add surroundingPairs

@msftclas
Copy link

msftclas commented Jun 7, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mjbvz mjbvz added this to the June 2017 milestone Jun 7, 2017
@mjbvz mjbvz merged commit fc2b063 into microsoft:master Jun 7, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 7, 2017

Thanks! Should be in the next VScode 1.14 insiders build once those start up again

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 7, 2017

I think we need to remove ` as an autoclosing pair. It makes typing fenced code blocks pretty annoying

mjbvz added a commit that referenced this pull request Jun 7, 2017
Having ` as an autoclosing pair makes typing fenced code blocks annoying

#28172 (comment)
@yzhang-gh
Copy link
Contributor Author

agree with you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants