Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix current output drop-down selected Issue #27643 #27645

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Fix current output drop-down selected Issue #27643 #27645

merged 1 commit into from
Jun 2, 2017

Conversation

cleidigh
Copy link
Contributor

Update selected active channel
with any new SetOptions call upon new output channel

@mention-bot
Copy link

@cleidigh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @bpasero to be potential reviewers.

@cleidigh cleidigh mentioned this pull request May 30, 2017
Closed
@isidorn
Copy link
Contributor

isidorn commented May 31, 2017 •
edited
Loading

@cleidigh looks good. However we are in endgame week and we are only testing and fixing critical bugs so it means I will merge it in next week.

Just out of curiosity does this surface as a bug somewhere?
Edit: only now I saw this issue, thanks! #27643

@isidorn isidorn added this to the June 2017 milestone May 31, 2017
@cleidigh
Copy link
Contributor Author

@isidorn
I assumed that..
Sounds good.

@isidorn isidorn merged commit f07f899 into microsoft:master Jun 2, 2017
@cleidigh cleidigh deleted the current-output-source/fix branch June 7, 2017 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@cleidigh @mention-bot @isidorn @msftclas