Better UX for recommended extensions #26089

teintinu · 2017-05-05T22:44:24Z

Intellisense for extensions.json providing installed extensions
Add to Workspace Recommendations context action
Install Workspace Recommended Extensions context action

from issue #13456

sandy081 · 2017-05-12T08:45:09Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

+		const action = <Action>this.instantiationService.createInstance(
+			ConfigureWorkspaceRecommendedExtensionsAction,
+			ConfigureWorkspaceRecommendedExtensionsAction.ID,
+			ConfigureWorkspaceRecommendedExtensionsAction.LABEL


Check for the case when there is no workspace.

Also why do we need to show the extensions file if we can just add the recommendation silently in the background.

sandy081 · 2017-05-12T08:46:46Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

+			ConfigureWorkspaceRecommendedExtensionsAction.LABEL
+		);
+		return action.run()
+			.then(() => this.extensionsWorkbenchService.addToWorkspaceRecommendations(this.extension));


Why not call the ExtensionTip service directly to add a recommendation?

sandy081 · 2017-05-12T09:19:51Z

@thr0w Thanks for the PR and your idea of enhancing workspace recommendations feature is good. I proposed some changes in my review. Please take a look and get back to me.

I am also ok, If you would like to split this into two separate PRs as the intellisense one looks complete and can be pushed.

Intelli-sense in extensions file
Provide actions to add/remove/install workspace recommendations

sandy081 · 2017-05-12T08:56:08Z

src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts

@@ -79,6 +79,27 @@ export class ExtensionTipsService implements IExtensionTipsService {
 		}, err => []);
 	}

+	addToWorkspaceRecommendations(extensionId: string): TPromise<void> {


Check if extensionId is valid or not

I would rather use workbench model service and json edit utility to update. This will retain the existing formatting options of the file. Refer ConfigurationEditingService that edits configuration files programatically.

sandy081 · 2017-05-12T08:59:10Z

src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts

+						}
+
+						const extension = result.firstPage[0];
+						const promises = [this.open(extension)];


Sorry.. I did not get why do we need to open extension

sandy081 · 2017-05-12T09:02:45Z

src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts

+						if (this.local.every(local => local.id !== extension.id)) {
+							promises.push(this.install(extension));
+						}
+


Not sure if I misunderstood.. I see it is installing only one recommended extensions in the list not all.. I do not see complete result is being read to install?

sandy081 · 2017-05-12T09:04:13Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

+		@IWorkspaceContextService private workspaceContextService: IWorkspaceContextService,
+		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
+		@IExtensionEnablementService private extensionEnablementService: IExtensionEnablementService,
+		@IInstantiationService private instantiationService: IInstantiationService


Please remove those services which are not used

sandy081 · 2017-05-12T09:05:15Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

+	}
+
+	protected isEnabled(): boolean {
+		return true;


It should not be enabled if there are no recommendations or all recommended extensions are already installed and also if there is a workspace or not

sandy081 · 2017-05-12T09:10:19Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
 	}
 }

+export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {


Since there is an action to add an extension to recommended list, there should also be a counter action to remove it from recommended list

sandy081 · 2017-05-12T09:14:36Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

@@ -358,6 +358,7 @@ export class ManageExtensionAction extends Action {
 				instantiationService.createInstance(EnableGloballyAction, localize('enableAlwaysAction.label', "Enable (Always)"))
 			],
 			[
+				instantiationService.createInstance(AddToWorkspaceRecommendationsAction, localize('addToWorkspaceRecommendationsAction.label', "Add to Workspace Recommendations")),


How about having a short label - Recommend (Workspace) and Unrecommend (Workspace). Not sure Workspace word is necessary since a user can recommend only to Workspace, but having it makes it complete.

sandy081 · 2017-05-12T09:15:41Z

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

+		label: string,
+		@IWorkspaceContextService contextService: IWorkspaceContextService,
+		@IViewletService private viewletService: IViewletService,
+		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService


Remove unused services

sandy081 · 2017-05-12T09:21:02Z

extensions/configuration-editing/src/extension.ts

+			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
+			if (location.path[0] === 'recommendations') {
+				return vscode.extensions.all
+					.filter(e => e.id.indexOf('vscode') === -1)


is this should ne e.id.startsWith('vscode.')?

sandy081 · 2017-05-12T09:21:44Z

extensions/configuration-editing/src/extension.ts

+			const location = getLocation(document.getText(), document.offsetAt(position));
+			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
+			if (location.path[0] === 'recommendations') {
+				return vscode.extensions.all


What do you suggest if there are no installed extensions?

teintinu · 2017-05-12T16:59:58Z

Hi @sandy081, thank you for your review, your comments and suggestions. I'll study and resolve each one. It's my first time with vscode sources. I learning yet.

As you suggested, I created #26564 for Intelli-sense in extensions file. In next week I'll create another PR providing actions to add/remove/install workspace recommendations (maybe I'll need some help with vscode source internals).

sandy081 · 2017-05-15T14:48:38Z

@thr0w Very much appreciated for your effort on this. Will definitely help you.. Please ask if you need any pointers or anything.

teintinu · 2017-05-16T18:52:05Z

@sandy081 these are my doubts:

How activate Extension Gallery when debuging vscode?
Can I use ManageExtensionAction.run to chang (or hide) Recommend / Unrecommend options, in case of extension yet recommending or not?
how mock/fake vscode with/without workspace to test Recommend/Unrecommend actions?

sandy081 · 2017-05-18T08:03:40Z

@thr0w

Please put following snippet in product.json file to enable querying extension gallery

"extensionsGallery": {
		"serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
		"cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
		"itemUrl": "https://marketplace.visualstudio.com/items"
	}

ManageExtensionAction shows only enabled actions. So set enable flag in Recommend / Unrecommend action
Open VSCode on a file or open a new VS Code window using File -> New Window which opens VS Code without workspace

sandy081 · 2018-06-11T09:49:22Z

Closing this as its no longer active

teintinu added 2 commits May 5, 2017 19:21

Better UX for recommended extensions microsoft#13456

70f9bb6

Merge remote-tracking branch 'upstream/master' into 13456

f03d091

msftclas added the cla-already-signed label May 5, 2017

kieferrm assigned sandy081 May 5, 2017

sandy081 added this to the May 2017 milestone May 8, 2017

sandy081 requested review from joaomoreno and sandy081 May 8, 2017 21:12

sandy081 reviewed May 12, 2017

View reviewed changes

sandy081 requested review from sandy081 and removed request for joaomoreno May 12, 2017 09:16

sandy081 reviewed May 12, 2017

View reviewed changes

teintinu mentioned this pull request May 12, 2017

Intelli-sense in extensions file #26564

Merged

sandy081 modified the milestones: June 2017, May 2017 May 30, 2017

sandy081 modified the milestones: Backlog, June 2017 Jun 26, 2017

msftgits removed the cla-already-signed label Sep 26, 2017

microsoft deleted a comment from msftclas Sep 27, 2017

sandy081 added the extensions Issues concerning extensions label Dec 4, 2017

sandy081 closed this Jun 11, 2018

teintinu deleted the 13456 branch June 13, 2018 22:54

github-actions bot locked and limited conversation to collaborators Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better UX for recommended extensions #26089

Better UX for recommended extensions #26089

teintinu commented May 5, 2017

sandy081 May 12, 2017 •

edited

Loading

sandy081 May 12, 2017

sandy081 commented May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

sandy081 May 12, 2017

teintinu commented May 12, 2017

sandy081 commented May 15, 2017

teintinu commented May 16, 2017 •

edited

Loading

sandy081 commented May 18, 2017

sandy081 commented Jun 11, 2018

Better UX for recommended extensions #26089

Better UX for recommended extensions #26089

Conversation

teintinu commented May 5, 2017

sandy081 May 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sandy081 commented May 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teintinu commented May 12, 2017

sandy081 commented May 15, 2017

teintinu commented May 16, 2017 • edited Loading

sandy081 commented May 18, 2017

sandy081 commented Jun 11, 2018

sandy081 May 12, 2017 •

edited

Loading

teintinu commented May 16, 2017 •

edited

Loading