Editor GPU: Add viewport render strategy #238487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of dealing with scroll offset for now, just increase column cap significantly
Tyriar
changed the title
TylerLeonhardt
approved these changes
Jan 22, 2025
legomushroom
pushed a commit
that referenced
this pull request
Jan 22, 2025
…er_strat Editor GPU: Add viewport render strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227108 (up to 2000 columns)
Fixes #227091
This adds a new "render strategy" that is designed to only renders the data in the viewport that is switched to dynamically when line count or column count is too large for the full file render strategy. Ideally this would only do the viewport from scroll x/y, but instead the whole line is uploaded and it supports up to 2000 character lines for now as doing it this way requires no changes to the shader.