Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Enablement of EditContext on Insiders #235062

Merged

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Dec 3, 2024

Reverts #234888

Fixes smoke test failures, need to investigate in my own time

@aiday-mar aiday-mar changed the title Revert "Enable EditContext by default on Insiders" Revert Enablement of EditContext on Insiders Dec 3, 2024
@aiday-mar aiday-mar marked this pull request as ready for review December 3, 2024 07:25
@aiday-mar aiday-mar enabled auto-merge (squash) December 3, 2024 07:25
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Dec 3, 2024
@aiday-mar aiday-mar merged commit 45385e1 into main Dec 3, 2024
8 checks passed
@aiday-mar aiday-mar deleted the revert-234888-revert-234638-revert-234181-vertical-gull branch December 3, 2024 07:37
aiday-mar added a commit that referenced this pull request Dec 5, 2024
aiday-mar added a commit that referenced this pull request Jan 7, 2025
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1.

* adding product import
aiday-mar added a commit that referenced this pull request Jan 13, 2025
* Revert "Revert Enablement of EditContext on Insiders (#235062)"

This reverts commit 45385e1.

* adding product import

* adding som code

* removing console logs

* make sure editor selection is observed after keybinding dispatches

Co-authored-with: Aiday Mar <amarlenkyzy@microsoft.com>

* removing empty lines

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants