Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit API names and remove findFiles2New and aiTextSearchProviderNew #232431

Merged
merged 14 commits into from
Oct 30, 2024
Merged

edit API names and remove findFiles2New and aiTextSearchProviderNew #232431

merged 14 commits into from
Oct 30, 2024

Conversation

andreamah
Copy link
Contributor

@andreamah andreamah commented Oct 28, 2024 •
edited
Loading

References #232430

  • The contents of findFiles2 will now have whatever findFiles2New had.
  • The contents of aiTextSearchProvider will now have whatever aiTextSearchProviderNew had.
  • findFiles2New is deleted
  • aiTextSearchProviderNew is deleted.

@andreamah andreamah self-assigned this Oct 28, 2024
@andreamah andreamah mentioned this pull request Oct 28, 2024
Merged
@andreamah andreamah marked this pull request as ready for review October 30, 2024 00:24
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Oct 30, 2024
justschen
justschen previously approved these changes Oct 30, 2024
View reviewed changes
justschen
justschen approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@justschen justschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andreamah andreamah merged commit 3551cb0 into main Oct 30, 2024
8 checks passed
@andreamah andreamah deleted the andreamah/issue232430 branch October 30, 2024 01:41
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justschen justschen justschen approved these changes

Assignees

@andreamah andreamah

Labels
None yet
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@andreamah @justschen