include temp ~ files in default exclusions #228981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Do you mind opening an associated feature request so we can gauge community interest and have open discussions there while keeping the PR focused on the actual code changes. With changing defaults like this we tend to be hesitant until there is enough community feedback for it. The feature request will also let us better track this work item. |
|
Yes, that's reasonable and also allows to discuss more additions - #229076. |
lassestilvang
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not aware of any environment that stores files ending with ~ that are not purely temporary, but several build and other software that uses those for temporary files,
I suggest to have this in the default exclusions, similar to Thumbs.db (which is Win32 specific) and .DS_Store (Macos specific) as a quite portable definition of temporary files.