Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish getting started page (fix #226991) #226994

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Polish getting started page (fix #226991) #226994

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1a8060
fix #226991
PhantomPower82 Aug 28, 2024
ccc0b5d
style: use tab
PhantomPower82 Aug 29, 2024
121ade6
Merge branch 'main' into fix-226991
bpasero Aug 30, 2024
14fbb05
Merge branch 'main' into fix-226991
bhavyaus Sep 9, 2024
14d7174
Merge branch 'main' into fix-226991
PhantomPower82 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/vs/workbench/contrib/welcomeGettingStarted/browser/media/gettingStarted.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@
.monaco-workbench .part.editor > .content .gettingStartedContainer .gettingStartedSlideCategories .featured-icon {
font-size: 20px;
padding-right: 8px;
position: relative;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property can be deleted or not since using position: relative without top: 3px works the same as position: static (default value) for the element itself (https://stackoverflow.com/a/13394093)

top: 3px;
}

.monaco-workbench .part.editor > .content .gettingStartedContainer .gettingStartedSlideCategories .codicon:not(.icon-widget, .featured-icon, .hide-category-button) {
Expand Down Expand Up @@ -926,8 +924,17 @@
text-decoration: var(--text-link-decoration);
}

.monaco-workbench .part.editor > .content .gettingStartedContainer .start-container .button-link {
line-height: 24px;
}

.monaco-workbench .part.editor > .content .gettingStartedContainer .button-link span {
vertical-align: middle;
}

.monaco-workbench .part.editor > .content .gettingStartedContainer .button-link .codicon {
color: var(--vscode-textLink-foreground);
vertical-align: middle;
}

.monaco-workbench .part.editor > .content .gettingStartedContainer a:not(.hide-category-button):hover {
Expand Down