Try to fix typings perf issues on web #224640
Merged
+128
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft#182791 With this change, we now make a single call to the package manager per root instead of per package. This simplifies the code and should be better for perf Still seeing a bunch of errors in the console but TS typing is working ok. Needs more exploration for ATA
mjbvz
changed the title
justschen
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #182791
With this change, we now make a single call to the package manager per root instead of per package. This simplifies the code and should be better for perf
Still seeing a bunch of errors in the console but TS typing is working ok. Needs more exploration for ATA
cc @zkat