Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Command Description in _getAllCommands #209260

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Include Command Description in _getAllCommands #209260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/vs/workbench/contrib/preferences/browser/preferencesActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { Extensions, IConfigurationRegistry } from 'vs/platform/configuration/co
import { EditorExtensionsRegistry } from 'vs/editor/browser/editorExtensions';
import { MenuId, MenuRegistry, isIMenuItem } from 'vs/platform/actions/common/actions';
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { isLocalizedString } from 'vs/platform/action/common/action';

export class ConfigureLanguageBasedSettingsAction extends Action {

Expand Down Expand Up @@ -83,21 +84,33 @@ CommandsRegistry.registerCommand({
//#region --- Register a command to get all actions from the command palette
CommandsRegistry.registerCommand('_getAllCommands', function (accessor) {
const keybindingService = accessor.get(IKeybindingService);
const actions: { command: string; label: string; precondition?: string; keybinding: string }[] = [];
const actions: { command: string; label: string; keybinding: string; description?: string; precondition?: string }[] = [];
for (const editorAction of EditorExtensionsRegistry.getEditorActions()) {
const keybinding = keybindingService.lookupKeybinding(editorAction.id);
actions.push({ command: editorAction.id, label: editorAction.label, precondition: editorAction.precondition?.serialize(), keybinding: keybinding?.getLabel() ?? 'Not set' });
actions.push({
command: editorAction.id,
label: editorAction.label,
description: isLocalizedString(editorAction.metadata?.description) ? editorAction.metadata.description.value : editorAction.metadata?.description,
precondition: editorAction.precondition?.serialize(),
keybinding: keybinding?.getLabel() ?? 'Not set'
});
}
for (const menuItem of MenuRegistry.getMenuItems(MenuId.CommandPalette)) {
if (isIMenuItem(menuItem)) {
const title = typeof menuItem.command.title === 'string' ? menuItem.command.title : menuItem.command.title.value;
const category = menuItem.command.category ? typeof menuItem.command.category === 'string' ? menuItem.command.category : menuItem.command.category.value : undefined;
const label = category ? `${category}: ${title}` : title;
const description = isLocalizedString(menuItem.command.metadata?.description) ? menuItem.command.metadata.description.value : menuItem.command.metadata?.description;
const keybinding = keybindingService.lookupKeybinding(menuItem.command.id);
actions.push({ command: menuItem.command.id, label, precondition: menuItem.when?.serialize(), keybinding: keybinding?.getLabel() ?? 'Not set' });
actions.push({
command: menuItem.command.id,
label,
description,
precondition: menuItem.when?.serialize(),
keybinding: keybinding?.getLabel() ?? 'Not set'
});
}
}
return actions;
});
//#endregion

Loading