Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for the apt repository #203833

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Use HTTPS for the apt repository #203833

merged 1 commit into from
Jan 31, 2024

Conversation

fmarier
Copy link
Contributor

@fmarier fmarier commented Jan 30, 2024

Fix for #203832

How to test:

  1. Build the .deb package.
  2. dpkg -i the freshly-built package.
  3. Look in /etc/apt/sources.list.d/vscode.list for an https:// URL.

@fmarier
Copy link
Contributor Author

fmarier commented Jan 30, 2024

It could also be worthwhile to upgrade existing installations similar to

elif grep -Eq "http:\/\/packages\.microsoft\.com\/repos\/vscode" $CODE_SOURCE_PART; then
# Migrate from old repository
WRITE_SOURCE=1
, but this requires building and testing and I don't have time for that right now. I suggest we leave that for a future follow-up.

This PR will at least address new installations.

@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2024

This was proposed before in #57992 (comment), you can see the reasoning for it being plain http there

@Tyriar Tyriar closed this Jan 30, 2024
@fmarier
Copy link
Contributor Author

fmarier commented Jan 31, 2024

@Tyriar That reasoning made sense 6 years ago, but if you look at https://packages.debian.org/unstable/apt-transport-https, apt-transport-https is no longer a separate package since the functionality was moved to apt directly in version 1.5.

The oldest supported version of Ubuntu (18.04) uses apt 1.6 and the oldest supported version of Debian (10) uses apt 1.8. Therefore, this will be a seamless upgrade for new installs.

I don't have the permissions to reopen this PR, so please consider this a request for re-review.

@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2024

Nice, thanks for the follow up!

@rzhao271 FYI, could you take a quick look and approve this, want to make sure you're aware in case anything goes wrong.

@Tyriar Tyriar reopened this Jan 31, 2024
@Tyriar Tyriar added this to the February 2024 milestone Jan 31, 2024
@rzhao271 rzhao271 merged commit 3d15752 into microsoft:main Jan 31, 2024
6 checks passed
@fmarier fmarier deleted the patch-1 branch January 31, 2024 21:47
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants