fix: terminal suggestion positioning #199420
Conversation
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
| if (!dimensions.width || !dimensions.height) { | ||
| return; | ||
| } | ||
| // TODO: What do frozen and auto do? | ||
| const xtermBox = this._terminal.element.getBoundingClientRect(); | ||
| const xtermBox = this._terminal.element!.querySelector('.xterm-screen')!.getBoundingClientRect(); |
There was a problem hiding this comment.
Using the .xterm-screen div instead of the terminal element since the suggestions need to account for the gap used to display the command controls.
Without the adjustment:
The terminal command controls gap
There was a problem hiding this comment.
Looks great! I'll merge this when we branch the release off (likely this Friday). In the meantime if you want to build more upon this you can checkout with this branch as the base and make the PR against that:
git checkout fix/terminal-suggestion-positioning
git checkout -b fix/terminal-suggestion-positioning__second
Or just independently if they don't conflict
| private _getTerminalDimensions(): { width: number; height: number } { | ||
| return { | ||
| width: (this._terminal as any)._core._renderService.dimensions.css.cell.width, | ||
| height: (this._terminal as any)._core._renderService.dimensions.css.cell.height, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Here's a slightly safer way of doing this:
((this._terminal as any)._core as IXtermCore)._renderService.dimensions.css.cell.heightWe can also pull _core out on activate so we just do the cast a single time.
| if (!dimensions.width || !dimensions.height) { | ||
| return; | ||
| } | ||
| // TODO: What do frozen and auto do? | ||
| const xtermBox = this._terminal.element!.getBoundingClientRect(); | ||
| const xtermBox = this._terminal.element!.querySelector('.xterm-screen')!.getBoundingClientRect(); |
There was a problem hiding this comment.
If/when we move SuggestAddon into a terminalContrib we can do this a single time in ITerminalContribution.xtermOpen
Description
Fixes the position of the terminal suggestions modal.
Testing