Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java workspace tags #197729

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

Flanker32
Copy link
Member

Changes

  • Update workspace tagging rules for Java, add new tags for azure-cosmos, azure-storage-account, azure-service-bus, azure-event-hub, openai, quarkus, microprofile, micronaut, GraalVM
  • Refactor logic for java workspace tagging, using string operations instead of Regex to improve perf

@deepak1556 deepak1556 assigned alexr00 and unassigned deepak1556 Nov 8, 2023
@alexr00 alexr00 assigned bpasero and unassigned alexr00 Nov 8, 2023
@bpasero bpasero assigned lramos15 and unassigned bpasero Nov 8, 2023
@lramos15 lramos15 assigned isidorn and unassigned lramos15 Nov 27, 2023
@lramos15 lramos15 self-requested a review November 27, 2023 16:51
@isidorn
Copy link
Contributor

isidorn commented Nov 28, 2023

This looks reasonable to me and Java is an important language to us.
However we want to limit this file from growing infinitely. @Flanker32 are all the packages you added really needed for data insights for your team? Can we trim down this list?

fyi @akaroml

@Flanker32
Copy link
Member Author

This looks reasonable to me and Java is an important language to us. However we want to limit this file from growing infinitely. @Flanker32 are all the packages you added really needed for data insights for your team? Can we trim down this list?

fyi @akaroml

@isidorn Thanks a lot for your help and sorry for the late response. I'm syncing with our PM to discuss whether some properties could be removed and simplify the logic here.

@isidorn isidorn added this to the December 2023 milestone Dec 6, 2023
@isidorn isidorn enabled auto-merge December 6, 2023 15:01
@isidorn
Copy link
Contributor

isidorn commented Dec 6, 2023

This looks good to me. Thank you for cleaning up the PR. We will merge it in soon-ish.

@isidorn isidorn merged commit 626122e into microsoft:main Dec 6, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants