Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-hide search icon #197577

Merged
merged 3 commits into from
Nov 7, 2023
Merged

aria-hide search icon #197577

merged 3 commits into from
Nov 7, 2023

Conversation

gtritchie
Copy link
Contributor

fix #197576

Added aria-hidden to the element to remove it from accessibility tree. This element has no accessible text but was reachable via VoiceOver on Mac (and then announced nothing). Now it will be skipped altogether (just like it is on Windows screen readers).

@meganrogge meganrogge added this to the November 2023 milestone Nov 6, 2023
@meganrogge meganrogge enabled auto-merge November 6, 2023 19:05
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meganrogge meganrogge requested a review from jrieken November 6, 2023 19:05
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@meganrogge meganrogge merged commit b4edfe8 into microsoft:main Nov 7, 2023
5 checks passed
amunger pushed a commit that referenced this pull request Nov 9, 2023
amunger pushed a commit that referenced this pull request Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magnifying glass icon in top search can be browsed with VoiceOver but says nothing
3 participants