Adopt EnvironmentVariableCollection in git ext

[Tyriar]

Fixes #184331

[lszomoru]

Thanks for the PR. I think that:

1. We should localize this string
2. It should be more generic as the functionality also depends on various settings (ex: Git: Enables git experiences in the integrated terminal

[Tyriar]

Opps forgot to localize.

It should be more generic as the functionality also depends on various settings (ex: Git: Enables git experiences in the integrated terminal

Could we be more explicit here and tailor strings for each set of values? "git experiences" is very mysterious still. I see git editor which I understand but is the IPC Server one only used for askpass or?

[lszomoru]

Yeah, the two things are the git commit message editor, and askpass integration.

[Tyriar]

I improved the message but I'm not sure how to do localization in an extension, I've never done it before and I don't see existing examples in the git extension used outside of the package.json?

[lszomoru]

Localization sample -

vscode/extensions/git/src/commands.ts

Lines 52 to 53 in 70daab7

	return l10n.t('Tag at {0}', this.shortCommit);
	}