Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextmenu duplicates workbenchactionexecuted events (fix #172640) #184299

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 5, 2023

This pushes the option to skip telemetry all the way down to the widgets that use the context menu. I found no other way because typically telemetry is logged from an "action runner" for all actions, irrespective if the action is shown as a button in the primary toolbar or the context menu. As such, the other idea of overriding the telemetry source (from: "contextMenu") to something else is not really practical I found.

@bpasero bpasero enabled auto-merge (squash) June 5, 2023 05:57
@bpasero bpasero requested a review from sbatten June 5, 2023 05:57
@bpasero bpasero self-assigned this Jun 5, 2023
@bpasero bpasero added this to the June 2023 milestone Jun 5, 2023
@Giangpro89 Giangpro89 linked an issue Jun 6, 2023 that may be closed by this pull request
@bpasero bpasero merged commit 3da8c69 into main Jun 6, 2023
@bpasero bpasero deleted the ben/grubby-piranha branch June 6, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://wikitech.wikimedia.org/wiki/Help:Toolforge/Jobs_framework
2 participants