Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Terminals aren't persisting anymore #183516

Merged
merged 3 commits into from
May 27, 2023
Merged

Fix Terminals aren't persisting anymore #183516

merged 3 commits into from
May 27, 2023

Conversation

jeanp413
Copy link
Contributor

Fixes #183445

@jeanp413 jeanp413 mentioned this pull request May 26, 2023
Closed
@meganrogge meganrogge added this to the May 2023 milestone May 26, 2023
Tyriar
Tyriar previously approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meganrogge LGTM if it's working for you, I haven't tested

@meganrogge
Copy link
Contributor

Thanks @jeanp413 for looking into this! Your fix works 🎉 , but some terminal API tests are failing at the moment. Rerunning to see if it was just a flake

@meganrogge
Copy link
Contributor

They're only failing on windows, which is odd

@jeanp413
Copy link
Contributor Author

@meganrogge should work now 🙂

@meganrogge meganrogge enabled auto-merge May 27, 2023 00:32
@meganrogge meganrogge merged commit eef30e7 into microsoft:main May 27, 2023
@meganrogge
Copy link
Contributor

I was stumped by this one @jeanp413. thank you again.

@jeanp413 jeanp413 deleted the fix-183445 branch May 27, 2023 02:41
@meganrogge meganrogge mentioned this pull request May 31, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@Tyriar Tyriar Tyriar left review comments

Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Terminals aren't persisting anymore
4 participants
@jeanp413 @meganrogge @Tyriar @TylerLeonhardt