Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive editor accessibility help polish #183356

Closed
wants to merge 7 commits into from

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented May 24, 2023

fix https://github.com/microsoft/vscode-copilot/issues/296
fix https://github.com/microsoft/vscode-internalbacklog/issues/4174

the request action doesn't work now when the help menu is shown ✅ but the button doesn't have disabled styling. thoughts @jrieken?

style.mov

@meganrogge meganrogge requested a review from jrieken May 24, 2023 18:23
@meganrogge meganrogge self-assigned this May 24, 2023
@meganrogge meganrogge added this to the May 2023 milestone May 24, 2023
@meganrogge meganrogge changed the title try to disable make request button when in help menu disable make request button when in help menu May 24, 2023
@meganrogge meganrogge marked this pull request as draft May 24, 2023 18:26
@meganrogge meganrogge changed the title disable make request button when in help menu interactive editor accessibility help polish May 24, 2023
@meganrogge meganrogge marked this pull request as ready for review May 25, 2023 17:17
rzhao271
rzhao271 previously approved these changes May 25, 2023
@rzhao271
Copy link
Contributor

Conflicts. Could this PR be rebased so that the other commits don't show up?

@meganrogge meganrogge closed this Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@meganrogge meganrogge deleted the merogge/disable-button branch October 26, 2023 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants