Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new extension host restart lifecycle (#180514) #183293

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented May 24, 2023

This completes #180514. Comments inline.

@bpasero bpasero enabled auto-merge (squash) May 24, 2023 05:04
@bpasero bpasero marked this pull request as draft May 24, 2023 05:04
auto-merge was automatically disabled May 24, 2023 05:04

Pull request was converted to draft

@bpasero bpasero requested review from lszomoru and rebornix May 24, 2023 05:16
@bpasero bpasero self-assigned this May 24, 2023
@bpasero bpasero added this to the May 2023 milestone May 24, 2023
@bpasero bpasero marked this pull request as ready for review May 24, 2023 05:16
rebornix
rebornix previously approved these changes May 24, 2023
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Having the veto in notebook model makes sense to me as it has working copy.

@bpasero bpasero enabled auto-merge (squash) May 24, 2023 06:22
@bpasero bpasero merged commit 0ef5dff into main May 25, 2023
@bpasero bpasero deleted the ben/curved-baboon branch May 25, 2023 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants