Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkProposedApiEnabled check when using env collection workspace proposal #183255

Merged
merged 4 commits into from
May 24, 2023
Merged

Add checkProposedApiEnabled check when using env collection workspace proposal #183255

merged 4 commits into from
May 24, 2023

Conversation

karrtikr
Copy link
Contributor

Closes #182966

@karrtikr karrtikr requested a review from Tyriar May 23, 2023 18:59
@vscodenpa vscodenpa added this to the May 2023 milestone May 23, 2023
@karrtikr karrtikr mentioned this pull request May 23, 2023
Merged
Tyriar
Tyriar previously approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, used the wrong method that throws

@Tyriar
Copy link
Member

Tyriar commented May 23, 2023

Need to add the proposed APIs to the vscode api tests package.json

Tyriar
Tyriar previously approved these changes May 23, 2023
View reviewed changes
@Tyriar Tyriar enabled auto-merge May 23, 2023 19:46
@karrtikr karrtikr requested a review from Tyriar May 23, 2023 20:11
@Tyriar Tyriar merged commit 79ea041 into main May 24, 2023
@Tyriar Tyriar deleted the kartik/initial-scallop branch May 24, 2023 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@karrtikr karrtikr

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Add isProposedApiEnabled check for env var scope
3 participants
@karrtikr @Tyriar @vscodenpa