Organize Errors in GitHub Auth and make sure no double prompting happens #180734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly just moves some strings into variables... but this also fixes the GH Auth side of #180697 so you should only be asked once if you want to try a different way to log in.
joyceerhl
reviewed
Apr 24, 2023
|
|
||
| const TIMED_OUT_ERROR = 'Timed out'; | ||
| const CANCELLATION_ERROR = 'Cancelled'; | ||
| const USER_CANCELLATION_ERROR = 'User Cancelled'; |
There was a problem hiding this comment.
Do these strings ever end up in UI somewhere (e.g. an uncaught error) that gets bubbled up into an error modal? If so, could we make these a little more descriptive?
There was a problem hiding this comment.
They shouldn't. CANCELLATION_ERROR is thrown to extensions calling getSession({ createIfNone: true })... but the others are totally internal.
It's kinda been this unspoken contract that an extension can handle cancelation accordingly by checking for the error message Cancelled. It should be more apparent, but that's out of scope of this PR.
There was a problem hiding this comment.
I added some comments
joyceerhl
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just moves some strings into variables... but this also fixes the GH Auth side of #180697 so you should only be asked once if you want to try a different way to log in.