Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _activeTasks synchronous wrt _executeTask #180617

Merged
merged 14 commits into from
May 4, 2023
Merged

Make _activeTasks synchronous wrt _executeTask #180617

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c9fb898
Make _activeTasks synchronous wrt _executeTask
Apr 22, 2023
fe67dd6
Fix dependency cycle detection
Apr 24, 2023
fda6f9c
Remove some redundant code handling sequential dependencies
Apr 24, 2023
38ac734
Never launch more than one copy of a dependent task
Apr 25, 2023
73ea851
polish
meganrogge May 1, 2023
08929a2
rm from liveDependencies/encounteredTasks
meganrogge May 2, 2023
ff7d86a
rm accidental additions
meganrogge May 2, 2023
0476301
don't update encounteredTasks
meganrogge May 2, 2023
3b80fb2
Make it clear that the modification to liveDependencies is local
May 2, 2023
05dce49
apply suggestions
meganrogge May 2, 2023
9b32200
Merge branch 'main' into synchronous-execute-task
meganrogge May 3, 2023
4ef0c3f
Merge branch 'main' into synchronous-execute-task
meganrogge May 3, 2023
4c69f53
separate issues
meganrogge May 3, 2023
0a2835a
revert change
meganrogge May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,9 +600,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
});
}
}).finally(() => {
const commonKey = task.getCommonTaskId();
liveDependencies.delete(commonKey);
encounteredTasks.delete(commonKey);
liveDependencies.delete(task.getCommonTaskId());
meganrogge marked this conversation as resolved.
Show resolved Hide resolved
if (this._activeTasks[mapKey] === activeTask) {
delete this._activeTasks[mapKey];
}
Expand Down