Allow repeated arrow-right expansion of unresolved folders when filtering a tree (#177444) #180055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @joaomoreno |
|
Pinging @lramos15 because though this applies to all trees it is particularly relevant in Explorer and I would like it to be considered for inclusion in 1.78 before endgame starts next week. |
lramos15
approved these changes
Apr 19, 2023
|
Definitely hacky. When debugging, I observe the problem is actually that |
|
Closing in favor of #180704 Thanks any way @gjsjohnmurray! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #177444.
To test, open a folder that contains an unexpanded
node_modulessubfolder. Use Ctrl+F to filter the explorer tree for a contiguous string that doesn't occur in most filenames (for example.es). Focus onto the tree (e.g. by pressing ArrowDown after entering the filter string). Navigate tonode-modules, the hold down ArrowRight to expand folders repeatedly. When filtering hides a fully-resolved folder because it contains no matches, ArrowRight now correctly expands the next folder.