-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render multiple glyph margin decorations #179657
Conversation
The call to Could you perhaps explore enriching the Another thing that might happen is that users might want to opt out of this growing of the margin area, so maybe we need to add an editor option to limit the max glyph margin lane count. |
👍 Done in c322dd0
I added glyph-decorations-setting.mp4 |
From standup today there was some feedback on the approach this PR takes, and I also learned about some prior discussions here. I opened #179725 to get additional feedback on a new proposal and will rework this PR once we have settled on a better approach. |
Fixes #5923
For #176316, I'd like to render a share link decoration in the gutter if a whole line has been selected. This currently doesn't play nicely with breakpoint decorations so I took a stab at expanding the glyph margin to accommodate rendering multiple decorations.
In future we could also add the ability to associate decoration click targets with specific commands (and also update the testing/breakpoint decorations to handle click events), but I wanted to address just the rendering issue as a first pass.