Added support for breakpointWidget to automatically adapt to width wh… #179551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en editor size changes
roblourens
reviewed
Apr 10, 2023
| @@ -216,6 +216,13 @@ export class BreakpointWidget extends ZoneWidget implements IPrivateBreakpointWi | |||
| this.centerInputVertically(); | |||
| } | |||
|
|
|||
| protected override _onWidth(widthInPixel: number): void { | |||
There was a problem hiding this comment.
Maybe just call this._onWidth so this isn't duplicating logic? And the other one subtracts 113, I suppose that's for padding?
There was a problem hiding this comment.
Ok so what happened to the - 113? Also please call _onLayout from _onWidth, it feels odd to do it the other way to me.
rzhao271
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en editor size changes
fix #175944