Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding type ResizableContentWidget - using it for the content hover widget #178811

Merged
merged 75 commits into from
Jun 21, 2023
Merged

Adding type ResizableContentWidget - using it for the content hover widget #178811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
f6fc074
creating a generic resizable content widget type which can be used to…
aiday-mar Mar 31, 2023
ea010f6
adding code for the hover specific widgets and content widgets
aiday-mar Mar 31, 2023
f5c37fb
Adding some code
aiday-mar Mar 31, 2023
642b208
commenting some method
aiday-mar Mar 31, 2023
17ca49d
removed some of the errors appearing, verify it all works later
aiday-mar Mar 31, 2023
3687cff
resolving the cyclic dependency, the hover no longer appears, find ou…
aiday-mar Mar 31, 2023
4d13019
cleaning the code
aiday-mar Mar 31, 2023
27c777e
made sashes red in order to be able to debug
aiday-mar Mar 31, 2023
b7c313b
adding the content widget inside of showAt in order to have the conte…
aiday-mar Mar 31, 2023
3ed8eae
now we see the red sash after changing the layout
aiday-mar Mar 31, 2023
7d65d19
also adding the layxout of the element into the onContentsChanges fun…
aiday-mar Mar 31, 2023
a5e5f8d
find out why the widget disappears when you hover on it, simplify fur…
aiday-mar Mar 31, 2023
9dc9fe7
first simplify maximally and clean the code, then extract the common …
aiday-mar Mar 31, 2023
41d4ad3
changing the code so that hover does not disappear on hovering on the…
aiday-mar Apr 3, 2023
8f94dec
saving the changes
aiday-mar Apr 3, 2023
4b5622e
does no longer automatically disappear on sash click
aiday-mar Apr 3, 2023
c81cd86
changing the id to the correct id of the resizable hover widget
aiday-mar Apr 3, 2023
3387388
changing the pixel positions for better rendering
aiday-mar Apr 3, 2023
6365481
using the check on the horizontal scrollbar of height 10 in the onCon…
aiday-mar Apr 3, 2023
add96e1
removing 7 in the resize function
aiday-mar Apr 3, 2023
aadd76e
changing the pixel values
aiday-mar Apr 3, 2023
1b7f36c
removing some redundant code
aiday-mar Apr 3, 2023
f1a1c6d
updating where the rendering is directly in the content widget
aiday-mar Apr 3, 2023
cb0687b
adding code for enabling the correct sashes
aiday-mar Apr 3, 2023
72a9e3b
cleaning the code
aiday-mar Apr 3, 2023
5b5bd72
changing the pixel change
aiday-mar Apr 3, 2023
8a07e1d
cleaning the code
aiday-mar Apr 4, 2023
e7b4497
changing pixel sizes, need to further improve pixel sizes
aiday-mar Apr 4, 2023
94ae3ac
Adding a command in order to be able to clear the persisted hover sizes
aiday-mar Apr 4, 2023
73737cd
works on hovers with horizontal scroll-bar, find why does not work wi…
aiday-mar Apr 4, 2023
b7f7c5c
got rid of flickering with the help of an additional boolean
aiday-mar Apr 4, 2023
b027af8
chaning the lengths of the sashes in order for it to cover the right …
aiday-mar Apr 4, 2023
dbaa9f8
adding 7 to the maximum height in order to remove unexpected resizing
aiday-mar Apr 5, 2023
ce7edf5
resetting the maximum rendering height when hiding the content widget
aiday-mar Apr 5, 2023
06e49a3
separating into maximum rendering height and available space
aiday-mar Apr 5, 2023
1bc94f9
adding the very high element width and height initially in order to a…
aiday-mar Apr 5, 2023
4cdf211
adding two to the client height and client width after the layout in …
aiday-mar Apr 5, 2023
21b6dfc
using different code when persisting the size and when not
aiday-mar Apr 5, 2023
1840cc5
cleaning the code
aiday-mar Apr 5, 2023
a138a49
Cleaning the code
aiday-mar Apr 5, 2023
ab3ca52
cleaning the code
aiday-mar Apr 5, 2023
5a0c0bf
cleaing the code
aiday-mar Apr 5, 2023
3b51b77
placing the hover widget into the resizable content hover widget
aiday-mar Apr 5, 2023
182e3b5
Merge branch 'main' into aiday/addingResizableContentWidget
aiday-mar Apr 6, 2023
88d75f1
adding code inspired from the review for a complete resizable widget
aiday-mar Apr 11, 2023
1dbecae
adding the initial code into the example resizable content widget
aiday-mar Apr 12, 2023
955f6a0
setting the position, now the hover appears, need to clean the code
aiday-mar Apr 27, 2023
8341580
setting the position of the content widget inside of the showAt function
aiday-mar Apr 27, 2023
181d171
cleaning the code
aiday-mar Apr 27, 2023
25ef12a
Merge branch 'main' into aiday/addingResizableContentWidget
aiday-mar May 24, 2023
9846e04
cleaning the code
aiday-mar May 24, 2023
157a0f0
Merge branch 'main' into aiday/addingResizableContentWidget
aiday-mar May 30, 2023
0e15526
cleaning the code
aiday-mar May 30, 2023
bcd704a
placing the rendering preference code into the generic resizable cont…
aiday-mar May 30, 2023
79096b0
refactoring the code
aiday-mar May 30, 2023
ab7aefd
cleaning the code
aiday-mar May 30, 2023
bffeeb0
cleaning the code
aiday-mar May 30, 2023
9aca64d
removing the unecessary _visible variable, the context key already se…
aiday-mar May 30, 2023
b179537
cleaning the code
aiday-mar May 30, 2023
c49aa40
cleaning the code
aiday-mar Jun 12, 2023
01131a6
cleaning the code
aiday-mar Jun 12, 2023
c0aa848
cleaning the code
aiday-mar Jun 12, 2023
7f1a666
cleaning the code
aiday-mar Jun 12, 2023
991bde4
no longer access the sash sizes directly
aiday-mar Jun 16, 2023
994e9bf
removing the sash accessors
aiday-mar Jun 16, 2023
75befc2
cleaning the code
aiday-mar Jun 16, 2023
a1874cd
removing code that appears to be redundant, resetting the width
aiday-mar Jun 16, 2023
ebd5c65
changing the order of the code
aiday-mar Jun 16, 2023
48fa43b
simplifying the code, appears to not be useful
aiday-mar Jun 16, 2023
d689519
simplifying the code
aiday-mar Jun 16, 2023
18eb6fd
cleaning the code
aiday-mar Jun 16, 2023
d017077
cleaning the code
aiday-mar Jun 16, 2023
3ab9cbc
simplfying the code
aiday-mar Jun 16, 2023
b595dd8
renaming the variables
aiday-mar Jun 16, 2023
8220e28
making the code more clear
aiday-mar Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/vs/base/browser/ui/hover/hover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

.resizable-hover {
z-index: 50;
}

.monaco-hover {
cursor: default;
position: absolute;
Expand All @@ -28,7 +32,6 @@
}

.monaco-hover .markdown-hover > .hover-contents:not(.code-hover-contents) {
max-width: 500px;
word-wrap: break-word;
}

Expand Down
Loading