Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defined variable instead of internal property #178701

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

Wundero
Copy link
Contributor

@Wundero Wundero commented Mar 30, 2023

Fixes #173277.

The function being fixed defines a variable for finding the default profile, but doesn't use it in the actual search. This works fine if the _defaultProfileName is set properly, but if it is different from the config value, this loads the incorrect profile, causing the above issue.

@roblourens roblourens assigned Tyriar and meganrogge and unassigned roblourens Mar 30, 2023
@Tyriar Tyriar added this to the April 2023 milestone Mar 31, 2023
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@Tyriar Tyriar enabled auto-merge March 31, 2023 12:01
@Tyriar Tyriar merged commit bbfcb62 into microsoft:main Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

login shell in integrated terminal stopped working on 1.75.0
5 participants