chore: bump electron@22.11.0 #175843
Closed
chore: bump electron@22.11.0 #175843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for smoke testing https://monacotools.visualstudio.com/Monaco/_build/results?buildId=205079&view=results |
|
Tests were crashing because native modules are built with v8 headers from https://electronjs.org/headers which has memory cage enabled https://github.com/electron/electron/blob/c3f06ef037cb2eaf649d963f13d27265a68d7018/patches/node/build_ensure_v8_pointer_compression_sandbox_is_enabled_on_64bit.patch#L52 Disabling the cage in the headers was able to resolve the crash but now the question is how do we address it for native modules shipped with extensions that build off the above headers ? |
deepak1556
force-pushed
the
robo/update_electron
branch
from
71a4d41 to
80df165
Compare
deepak1556
force-pushed
the
robo/update_electron
branch
from
88e8e46 to
24f5828
Compare
|
We are not disabling the V8 sandbox, closing in favor of #177600 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables v8 memory cage temporarily for extensions depending on native modules to make the transition https://www.electronjs.org/blog/v8-memory-cage#i-want-to-refactor-a-node-native-module-to-support-electron-21-how-do-i-do-that