Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update minimum installable version in inno setup #175818

Merged
merged 4 commits into from
Jun 23, 2023
Merged

chore: update minimum installable version in inno setup #175818

merged 4 commits into from
Jun 23, 2023

Conversation

ChaseKnowlden
Copy link
Contributor

@ChaseKnowlden ChaseKnowlden commented Mar 2, 2023 •
edited
Loading

Refs: https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice

According to electron's website, electron 22 will be the last version to support windows 8/8.1.

@andreamah andreamah assigned deepak1556 and unassigned andreamah Mar 2, 2023
deepak1556
deepak1556 requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I will block this change until we send out deprecation notice and prepare for EOL.

/cc @isidorn @joaomoreno , refs https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice

We should handle the deprecation notice with v1.77 and allow enough time for Electron 23 adoption.

@isidorn
Copy link
Contributor

isidorn commented Mar 3, 2023

@deepak1556 thanks for the ping. What do you think we should do? Same flow as for Win7 deprecation?

@deepak1556
Copy link
Collaborator

Yup same flow as other previous deprecations. We already have the general structure setup in both client and server, so it will be easy to add new versions. I will create an issue for this deprecation.

@deepak1556 deepak1556 mentioned this pull request Mar 20, 2023
Merged
@deepak1556
Copy link
Collaborator

@ChaseKnowlden can you rebase on top of latest main, I think this change is good to go now that #177676 is resolved.

@ChaseKnowlden
Copy link
Contributor Author

Up-to-date. @deepak1556

Alibayat4545
Alibayat4545 reviewed Jun 22, 2023
View reviewed changes
Copy link

@Alibayat4545 Alibayat4545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2971

@deepak1556 deepak1556 changed the title Drop support for windows versions prior to windows 10 chore: update minimum installable version in inno setup Jun 22, 2023
deepak1556
deepak1556 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 added this to the June 2023 milestone Jun 22, 2023
@deepak1556 deepak1556 merged commit b603fcf into microsoft:main Jun 23, 2023
5 checks passed
@ChaseKnowlden ChaseKnowlden deleted the genuine-crab branch June 23, 2023 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Alibayat4545 Alibayat4545 Alibayat4545 left review comments

@joaomoreno joaomoreno joaomoreno approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.
7 participants
@ChaseKnowlden @isidorn @deepak1556 @joaomoreno @Alibayat4545 @andreamah @VSCodeTriageBot