Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer: auto create folder when file path ends with / #173901

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Explorer: auto create folder when file path ends with / #173901

merged 5 commits into from
Mar 20, 2023

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Feb 9, 2023 •
edited
Loading

Fixes #173902

@zardoy zardoy mentioned this pull request Feb 9, 2023
Closed
@lramos15
Copy link
Member

lramos15 commented Feb 9, 2023

I believe #162893 contains this

@zardoy
Copy link
Contributor Author

zardoy commented Feb 9, 2023

I believe #162893 contains this

@lramos15 No, I checked that it doesn't contain requested behavior (its about multiple creation). To check: double click on empty space in explorer (explorer.newFile), type dir/ - file with name dir is created instead of directory, also as I understand you're not happy with changes in that PR (though I also really like it!), so I think it shouldn't include it.

Also I'm not big of fan of redundant settings, so if you're happy enough to include it without setting, I'll remove it. Anyway please let me know what you think. thx!

@lramos15
Copy link
Member

lramos15 commented Mar 1, 2023

Let's remove the setting and make this a default behavior since test/foo.txt would already make a test folder with a file called foo.txt

@lramos15 lramos15 added this to the March 2023 milestone Mar 1, 2023
@zardoy
Copy link
Contributor Author

zardoy commented Mar 1, 2023

Totally makes sense, I just first try with a setting when it comes to user experience improved as I expect higher review/accept rate in this case. Anyway, now this PR has just 3 LOC 😄

@zardoy
Copy link
Contributor Author

zardoy commented Mar 20, 2023 •
edited
Loading

Just to check is there anything else required from my side for this to be merged?

@lramos15 lramos15 merged commit c9594ae into microsoft:main Mar 20, 2023
@lramos15
Copy link
Member

Nothing! Thanks for the contribution :)

alirazacs
alirazacs reviewed Apr 1, 2023
View reviewed changes
src/vs/workbench/contrib/files/browser/files.contribution.ts Outdated
@@ -478,6 +478,11 @@ configurationRegistry.registerConfiguration({
description: nls.localize('explorer.incrementalNaming', "Controls what naming strategy to use when a giving a new name to a duplicated Explorer item on paste."),
default: 'simple'
},
'explorer.autoCreateNewFolder': {
'type': 'boolean',
description: nls.localize('explorer.autoCreateNewFolder', "Wether to create folder when new file name input value ends with slash (`/`)."),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm, okay I guess. The code was removed, how did you leave the review?

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alirazacs alirazacs alirazacs left review comments

@lramos15 lramos15 lramos15 approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

Explorer: auto create folder when file path ends with /
4 participants
@zardoy @lramos15 @Tyriar @alirazacs