Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #156173 #170287

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix #156173 #170287

merged 1 commit into from
Dec 30, 2022

Conversation

sandy081
Copy link
Member

fix #156173

@sandy081 sandy081 enabled auto-merge (squash) December 30, 2022 11:26
@sandy081 sandy081 self-assigned this Dec 30, 2022
@sandy081 sandy081 requested a review from bpasero December 30, 2022 11:26
@vscodenpa vscodenpa added this to the January 2023 milestone Dec 30, 2022
@sandy081 sandy081 merged commit c53c123 into main Dec 30, 2022
bpasero
bpasero approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs any adoption for web as well? For example browserHostService?

@sandy081 sandy081 deleted the sandy081/extreme-hoverfly branch December 30, 2022 11:54
@sandy081
Copy link
Member Author

I would not do it now. Moreover, we do not support embedder options (like CLI options) in web yet.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Call vscode.openFolder command with profile/set of extensions (similar to #151301)
3 participants
@sandy081 @bpasero @vscodenpa