Prevent hiding unresolved tree branches #167047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjsjohnmurray
commented
Nov 23, 2022
| @@ -625,6 +625,9 @@ class FindFilter<T> implements ITreeFilter<T, FuzzyScore | LabelFuzzyScore>, IDi | |||
| } | |||
|
|
|||
| if (this.tree.findMode === TreeFindMode.Filter) { | |||
| if (element.hasChildren && element.childrenUnresolved) { | |||
There was a problem hiding this comment.
Problems reported on this line:
Property 'hasChildren' does not exist on type 'T'.
Property 'childrenUnresolved' does not exist on type 'T'.
What (if any) is the right way to resolve these?
There was a problem hiding this comment.
We can create an additional option for the tree:
readonly defaultFindVisibility?: TreeVisibility | ((e: T) => TreeVisibility);Will push commits to this branch.
|
/assign @joaomoreno |
|
Thanks for the effort and idea @gjsjohnmurray, this is a clever way to solve/mitigate this problem. Sorry it took me so long to get here! 🍻 Unsure if this PR should close #66971, IMO that's a larger work item. |
joaomoreno
approved these changes
Jan 2, 2023
joaomoreno
changed the title
bpasero
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my second attempt at resolving #66971, following feedback from @joaomoreno on my original PR (#164472).
I am submitting it as a draft because of the 2 ts(2339) problems it contains. I will add a comment to the offending line.