Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting timings (perf machine) shouldn't complain about missing cached data #165342

Merged
merged 1 commit into from
Nov 3, 2022
Merged

starting timings (perf machine) shouldn't complain about missing cached data #165342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/vs/workbench/contrib/performance/electron-sandbox/startupTimings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ import { IUpdateService } from 'vs/platform/update/common/update';
import { INativeHostService } from 'vs/platform/native/electron-sandbox/native';
import * as files from 'vs/workbench/contrib/files/common/files';
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
import { didUseCachedData } from 'vs/workbench/services/timer/electron-sandbox/timerService';
import { ITimerService } from 'vs/workbench/services/timer/browser/timerService';
import { IFileService } from 'vs/platform/files/common/files';
import { URI } from 'vs/base/common/uri';
import { VSBuffer } from 'vs/base/common/buffer';
import { IWorkspaceTrustManagementService } from 'vs/platform/workspace/common/workspaceTrust';
import { IStorageService } from 'vs/platform/storage/common/storage';
import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/browser/panecomposite';
import { ViewContainerLocation } from 'vs/workbench/common/views';

Expand All @@ -39,7 +37,6 @@ export class StartupTimings implements IWorkbenchContribution {
@INativeWorkbenchEnvironmentService private readonly _environmentService: INativeWorkbenchEnvironmentService,
@IProductService private readonly _productService: IProductService,
@IWorkspaceTrustManagementService private readonly _workspaceTrustService: IWorkspaceTrustManagementService,
@IStorageService private readonly _storageService: IStorageService
) {
this._report().catch(onUnexpectedError);
}
Expand Down Expand Up @@ -110,10 +107,6 @@ export class StartupTimings implements IWorkbenchContribution {
if (activePanel) {
return 'Current active panel : ' + this._paneCompositeService.getPaneComposite(activePanel.getId(), ViewContainerLocation.Panel)?.name;
}
const noCachedData = this._environmentService.args['no-cached-data'];
if (!noCachedData && !didUseCachedData(this._productService, this._storageService, this._environmentService)) {
return 'Either cache data is rejected or not created';
}
if (!await this._updateService.isLatestVersion()) {
return 'Not on latest version, updates available';
}
Expand Down