Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comma splices in descriptions in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts #164401

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Conversation

hughlilly
Copy link
Contributor

This PR suggests a number of grammatical fixes in src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts, mostly to remedy comma splices.

@hughlilly
Copy link
Contributor Author

@microsoft-github-policy-service agree

meganrogge
meganrogge previously approved these changes Oct 24, 2022
@meganrogge meganrogge requested a review from Tyriar October 24, 2022 19:24
@meganrogge meganrogge added this to the October 2022 milestone Oct 24, 2022
Tyriar
Tyriar previously approved these changes Oct 24, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL I often use comma splices 👀

@Tyriar Tyriar enabled auto-merge October 24, 2022 19:49
auto-merge was automatically disabled October 24, 2022 20:29

Head branch was pushed to by a user without write access

@hughlilly hughlilly dismissed stale reviews from Tyriar and meganrogge via c22980c October 24, 2022 20:29
@hughlilly
Copy link
Contributor Author

Sorry, I think I might have made a mistake here; I was trying to add another commit.

@Tyriar Tyriar merged commit f95bfda into microsoft:main Oct 24, 2022
@hughlilly hughlilly deleted the comma-splice-fixes branch October 24, 2022 21:31
formigoni pushed a commit to formigoni/vscode that referenced this pull request Oct 27, 2022
Fix comma splices in descriptions in `src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts`
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants