-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-language-features] Add removeUnusedImports
command
#161654
Conversation
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
Let’s wait for microsoft/TypeScript#50931 in case there are any changes requested from the TypeScript side. |
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
@mjbvz I did quite a bit of reorganization to expose new command palette entries while reusing some of the code that already existed for the code actions on save. I tried it out and it seems to work, but I have a few questions I’ll leave inline, and let me know if you see anything that looks off. Thanks! |
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback but otherwise looking good!
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/organizeImports.ts
Show resolved
Hide resolved
@andrewbranch Looks like the compile is failing. Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
TS counterpart: microsoft/TypeScript#50931