Auto detect indentation when pasting on an empty file #156282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
approved these changes
Oct 24, 2022
aeschli
approved these changes
Oct 24, 2022
joyceerhl
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
Detect indentation Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #151304.
While working on it I noticed that it does not detect tab size (sets 4 as default) but only space size, and seems to be intentional:
vscode/src/vs/editor/common/model/indentationGuesser.ts
Lines 191 to 194 in 21ca44d
I'm mentioning that in case we want to change this behavior as I don't know why originally it has been decided.