-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes find widget shall be shown per split terminal #155361
Conversation
Thanks @jeanp413 for working on this. The code changes/clean-up look great 👍🏼 Github won't let me attach images or gifs ATM 😢 I notice a few things:
|
@meganrogge updated the PR, last commit is optional just some 💄 to match the findwidget behavior from a normal editor |
great @jeanp413 thanks. I was just working on fixing the two problems I mentioned above and will revert my fix as yours looks better 👍🏼 |
This reverts commit 030cf22.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, sorry about the delay 🙂
This PR fixes #145865